Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show in the console two or more weapons skins using the config #141 #164

Closed
wants to merge 10 commits into from
Closed

Conversation

JanEickholt
Copy link

just #161, but in a new branch now

JanEickholt and others added 3 commits July 31, 2023 06:00
usage in config:
"weapons": "Vandal, Phantom, ..."
https://legende.cc/ss/9670865ba4.png
made hiding the weapon suffix optional via the config
@zayKenyon zayKenyon added this to the 2.7 milestone Aug 1, 2023
@zayKenyon zayKenyon added question Further information is requested semver:minor feature request labels Aug 1, 2023
Copy link
Owner

@zayKenyon zayKenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of the config onboarding (when you run the app with the --config flag), users can input a weapon via InquirerPy, could you change this so they can make 2 inputs?

src/constants.py Outdated
Comment on lines 160 to 174
"skin_abbreviations": {
"status": True,
"abbreviations": {
"Gravitational Uranium Neuroblaster": "GUN",
"Radiant Entertainment System": "RES",
"VALORANT GO! Vol. 1": "V. G. Vol. 1",
"VALORANT GO! Vol. 2": "V. G. Vol. 2",
"Radiant Crisis 001": "RC 001",
"Sentinels of Light": "SoL",
"Prelude to Chaos": "PtC",
"Winterwunderland": "Winter",
"Kohaku & Matsuba": "K&M",
"Gaia's Vengeance": "Gaia"
}
},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously discussed: here.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also add Tethered Realms, Nunca Olvidados, Radiant Crisis 001, Protocol 781-A, Divine Swine, Lycan's Bane, Coalition Cobra, Task Force 809, Piedra del Sol, Premiere Collision, Starlit Odyssey.
There are many long skin names making all of them short will make it confusing but we need to have a good system for this other wise there wont be space left in the table.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also add Tethered Realms, Nunca Olvidados, Radiant Crisis 001, Protocol 781-A, Divine Swine, Lycan's Bane, Coalition Cobra, Task Force 809, Piedra del Sol, Premiere Collision, Starlit Odyssey.

I added all of them, that are longer than 10 characters

There are many long skin names making all of them short will make it confusing

I understand your point, but I would still appreciate suggestions on making it possible

src/config.py Outdated Show resolved Hide resolved
added all weapon skins to the abbreviations list, that are longer than 10 characters (suggestions wanted)
@JanEickholt
Copy link
Author

As part of the config onboarding (when you run the app with the --config flag), users can input a weapon via InquirerPy, could you change this so they can make 2 inputs?

I am unsure about the elegance of the code, but you can add multiple weapons now

@JanEickholt JanEickholt requested a review from zayKenyon August 3, 2023 11:34
@JanEickholt JanEickholt changed the title implemented #141 Show in the console two or more weapons skins using the config #141 Aug 27, 2023
@JanEickholt JanEickholt closed this by deleting the head repository Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request question Further information is requested semver:minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Show in the console two or more weapons skins using the config
3 participants